Review: libgbinder 1.1.45+ds-1
New Package Report
.changes
| Source | libgbinder |
|---|---|
| Version | 1.1.45+ds-1 |
| Changed-By | Seyed Mohamad Amin Modaresi |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sat, 25 Apr 2026 07:59:34 +0330 |
Changelog
libgbinder (1.1.45+ds-1) unstable; urgency=medium . * Initial release (Closes: #1134868)
.dsc
| Package-List | libgbinder-dev deb libdevel optional arch=any libgbinder-tools deb utils optional arch=any libgbinder1 deb libs optional arch=any |
|---|---|
| Section | libdevel |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/mer-hybris/libgbinder Upstream-Name: libgbinder Upstream-Contact: Slava Monich <slava@monich.com> Files-Excluded: debian Files: * Copyright: 2014-2024 Jolla Ltd. 2018-2026 Slava Monich <slava@monich.com> 2025-2026 Jolla Mobile Ltd. 2021 Gary Wang <gary.wang@canonical.com> 2021 Madhushan Nishantha <jlmadushan@gmail.com> 2021 Franz-Josef Haider <franz.haider@jolla.com> License: BSD-3-clause Files: debian/* Copyright: 2026 Seyed Mohamad Amin Modaresi <modaresisofthard@proton.me> License: BSD-3-clause License: BSD-3-clause Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: . 1) Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. . 2) Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. . 3) Neither the name of the ORGANIZATION nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Review Information
rejected — allocated to siretart 4 days ago, started 4 days ago, completed 4 days ago.
Final Comment
Thanks for your diligence in bringing libgbinder to the archive. It's a
valuable addition, but I've run into a few snags in debian/copyright
that we'll need to sort out before it can be accepted.
I noticed a slight slip in the attribution of several contributors. While
Jolla and Slava are well-represented, a few others who are credited
directly in the source headers have been missed in the copyright file.
Specifically:
- Gary Wang gary.wang@canonical.com is credited in several AIDL-related
files (like src/gbinder_servicemanager_aidl4.c). - Madhushan Nishantha jlmadushan@gmail.com also appears in those
same files. - Franz-Josef Haider franz.haider@jolla.com is credited in
test/binder-call/binder-call.c.
There's also a bit of a DFSG problem with src/binder.h. Since it's a
bundled header derived from the Linux kernel via the Android Bionic
project, it needs its own stanza acknowledging the original authors
(Linux Kernel Developers and Google), even if the header itself claims
to be non-copyrightable.
I also noticed that the BSD-3-clause license text in debian/copyright
seems to be a generic template rather than a verbatim copy of the
actual license used by the project. For instance, your text still
contains the "name of the ORGANIZATION" placeholder in the third
condition, whereas upstream has replaced this with "names of the
copyright holders." Similarly, the disclaimer in the source uses the
plural "COPYRIGHT HOLDERS," while your text is in the singular. For
a machine-readable copyright file, the text must be an exact verbatim
match of what's in the source (including numbering styles and
disclaimers), so please replace the template with the specific text
found in the LICENSE file.
Lastly, Slava Monich uses a couple of different email addresses across
the headers, and some files like the cmdline lexer/parser in the test
directory are missing headers entirely. It would be great to have those
all tidied up in the documentation.
Please take another look at the source and re-upload once these are
addressed. I'm looking forward to seeing this in the archive.
-rt