Review: liblsl 1.17.5-1
New Package Report
.changes
| Date | Mon, 13 Apr 2026 09:45:30 +0100 |
|---|---|
| Source | liblsl |
| Version | 1.17.5-1 |
| Changed-By | Christopher Obbard |
| Architecture | source amd64 |
| Distribution | unstable |
Changelog
liblsl (1.17.5-1) unstable; urgency=medium . * New upstream release. * d/control: shortern description * d/control: bump libboost-dev to 1.90 * d/control: add libcatch2-dev to B-d * d/patches: add patch to prefer system catch2 * d/patches: add patch to use public catch2 approx header * d/copyright: ensure paragraphs are correctly formatted * d/gbp.conf: update filter to match upstream * d/copyright: update Files-Excluded to match upstream * d/README.source: add instructions to update upstream release * d/control: bump Standards-Version to 4.7.4 * d/watch: add watch file * d/control: rename binary package liblsl1 to liblsl2 * d/copyright: use BSL-1.0 as Boost license short name * d/control: reformat file * d/liblsl-dev.*: sort files
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | liblsl-dev deb libdevel optional arch=any liblsl2 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: liblsl Source: https://github.com/sccn/liblsl Files-Excluded: lslboost thirdparty/asio thirdparty/asio_objects.cpp Files: * Copyright: Copyright (C) 2012 Christian A. Kothe License: MIT Files: src/portable_archive/* Copyright: Christian Pfligersdorffer <christian.pfligersdorffer@gmx.at> License: BSL-1.0 Files: thirdparty/loguru/* Copyright: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> License: Public-Domain Comment: https://github.com/emilk/loguru License: MIT Copyright (C) 2012 Christian A. Kothe . Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. License: Public-Domain This software is in the public domain. Where that dedication is not recognized, you are granted a perpetual, irrevocable license to copy, modify and distribute it as you see fit. . That being said, I would appreciate credit! If you find Loguru useful, tweet me at @ernerfeldt mail me at emil.ernerfeldt@gmail.com. License: BSL-1.0 Boost Software License - Version 1.0 - August 17th, 2003 . Permission is hereby granted, free of charge, to any person or organization obtaining a copy of the software and accompanying documentation covered by this license (the "Software") to use, reproduce, display, distribute, execute, and transmit the Software, and to prepare derivative works of the Software, and to permit third-parties to whom the Software is furnished to do so, all subject to the following: . The copyright notices in the Software and this entire statement, including the above license grant, this restriction and the following disclaimer, must be included in all copies of the Software, in whole or in part, and all derivative works of the Software, unless such copies or derivative works are solely in the form of machine-executable object code generated by a source language processor. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to awm 20 hours ago, started 20 hours ago, completed 19 hours ago.
Final Comment
Hi,
Looks like you missed a couple of authors in the debian/copyright...
liblsl_1.17.5-1$ grep -ri Kapoulkine .
./thirdparty/pugixml/pugiconfig.hpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com)
./thirdparty/pugixml/pugiconfig.hpp: * Copyright (c) 2006-2025 Arseny Kapoulkine
./thirdparty/pugixml/pugixml.hpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com)
./thirdparty/pugixml/pugixml.hpp: * Copyright (c) 2006-2025 Arseny Kapoulkine
./thirdparty/pugixml/pugixml.cpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com)
./thirdparty/pugixml/pugixml.cpp: * Copyright (c) 2006-2025 Arseny Kapoulkine
./thirdparty/pugixml/readme.txt:Copyright (C) 2006-2020, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com)
./thirdparty/pugixml/readme.txt:Copyright (c) 2006-2019 Arseny Kapoulkine
./LICENSE:pugixml (https://pugixml.org), MIT. pugixml is Copyright (C) 2006-2018 Arseny Kapoulkine.
liblsl_1.17.5-1$ grep -ri wegner .
./thirdparty/pugixml/pugiconfig.hpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net)
./thirdparty/pugixml/pugixml.hpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net)
./thirdparty/pugixml/pugixml.cpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net)
There's also the cmake/ios.toolchain.cmake perhaps having a BSD-3-Clause license,
but it's probably easiest to just exclude that file from Debian.
Thanks!
Public Notes
Search for authors
Command: ag -i 'copyright .* (by|rights|reserved)[. ]' | sed -e 's/^.*Copyright //i' -e 's/\(20\|19\)[0-9][0-9][, -]*//g' -e 's/[., ]*ALL RIGHTS RESERVED.*$//i' | sort -i | uniq -i
Exit code: 0
(C) by Arseny Kapoulkine (arseny.kapoulkine@gmail.com)
(C) by Kristen Wegner (kristen@tima.net)
Licenserecon
Command: lrc -s
Exit code: 3
en: Versions: licenserecon '14.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Missing Files: Paragraph for debian/
Running licensecheck ....
d/copyright | licensecheck
Expat | BSD-3-clause cmake/ios.toolchain.cmake
Short option in use. Not all differences shown