Review: librime 1.17.0+dfsg2-1
Package Information
| Description | Rime Input Method Engine RIME is the acronym of Rime Input Method Engine. RIME is a lightweight, extensible input method engine supporting various input schematas including glyph-based input methods, romanization-based input methods as well as those for Chinese dialects. It has the ability to compose phrases and sentences intelligently and provide very accurate traditional Chinese output. RIME's cross-platform core library is written in C++, and can work consistently on different platforms with OS-specific wrappers. |
|---|---|
| Maintainer | Debian Input Method Team <debian-input-method@lists.debian.org> |
| Changed By | Boyuan Yang <byang@debian.org> |
| Sponsor | byang@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/input-method-team/librime.git (browse) |
| Popcon Installs | 420 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/librime |
| Uploaded | 19 days ago |
New Package Report
.changes
| Source | librime |
|---|---|
| Version | 1.17.0+dfsg2-1 |
| Changed-By | Boyuan Yang <byang@debian.org> |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sat, 03 Oct 2026 10:06:39 -0400 |
Changelog
librime (1.17.0+dfsg2-1) unstable; urgency=medium
.
* Include source code for librime-predict extension.
* Add new binary package librime-plugin-predict.
+ debian/librime-plugin-predict.README.Debian: Document how to get
the prediction database and enable the plugin in a schema.
* Refresh plugin version:
+ octagram: 20260831. This fixes the encoding of code points outside
U+4000..U+9FFF, needed by the current octagram language models,
and relicenses the plugin under BSD-3-Clause.
* debian/patches/0003-plugins-install-the-data-build-tools.patch:
Install the build_predict and build_grammar tools.
* librime-bin: Ship them as rime_build_predict and rime_build_grammar.
* debian/patches/0004-dict-install-the-bundled-darts-clone-header.patch:
Ship the darts-clone header in librime-dev as rime/dict/darts.h, so
that the installed private header rime/dict/prism.h no longer picks
up /usr/include/darts.h from the darts package.
* debian/patches/0005-refactor-support-c-20.patch: Backport upstream
commit 7cb3e50a to make the installed private headers usable with
C++20, the default standard of GCC 16.
* debian/watch: Add librime-predict component; bump repack suffix
to +dfsg2.
* debian/gbp.conf: Add librime-predict component.
* debian/rules: Build the predict plugin with its own version number.
* debian/control:
+ Let librime1t64 recommend librime-plugin-predict.
+ Let librime-plugin-octagram suggest rime-data-octagram.
+ Drop unused build-dependency on darts. librime bundles darts-clone
(include/darts.h) and always builds against it; the darts package
is the incompatible original Darts library.
+ Let librime-dev suggest libboost-dev, libgoogle-glog-dev,
libmarisa-dev and x11proto-dev, which the installed private
headers include.
* debian/copyright:
+ Correct the license of the main source code to BSD-3-Clause, as
stated in upstream LICENSE and the file headers.
+ Add entries for cmake/RimeConfig.cmake and cmake/FindIconv.cmake.
+ Add entry for librime-predict.
+ Update license of librime-octagram to BSD-3-Clause.
+ Correct the entry for include/darts.h, which is darts-clone.
+ Use the BSD-3-Clause license text of upstream LICENSE..dsc
| Section | utils |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librime-bin deb utils optional arch=any librime-dev deb libdevel optional arch=any librime-plugin-charcode deb libs optional arch=any librime-plugin-lua deb libs optional arch=any librime-plugin-octagram deb libs optional arch=any librime-plugin-predict deb libs optional arch=any librime1t64 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: librime
Source: https://github.com/rime/librime
Files-Excluded:
bin/*
deps/*
include/utf8/*
include/utf8.h
Files: *
Copyright: 2011-2024, GONG Chen <chen.sst@gmail.com>
2014, RIME Developers
License: BSD-3-Clause
Files: cmake/RimeConfig.cmake
Copyright: 2012, Xuetian Weng
License: BSD-3-Clause
Files: cmake/FindIconv.cmake
Copyright: Eddy Xu <eddyxu@gmail.com>
License: BSD-3-Clause
Comment: The file only says "Released under BSD license". It is not used
in the Debian build: debian/patches/0002 removes it.
Files: include/X11/*
Copyright: 1987, 1994, 1988 The Open Group
1987, Digital Equipment Corporation
License: ISC-variant
Permission to use, copy, modify, distribute, and sell this software and its
documentation for any purpose is hereby granted without fee, provided that
the above copyright notice appear in all copies and that both that
copyright notice and this permission notice appear in supporting
documentation.
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
OPEN GROUP BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
.
Except as contained in this notice, the name of The Open Group shall not be
used in advertising or otherwise to promote the sale, use or other dealings
in this Software without prior written authorization from The Open Group.
.
Permission to use, copy, modify, and distribute this software and its
documentation for any purpose and without fee is hereby granted,
provided that the above copyright notice appear in all copies and that
both that copyright notice and this permission notice appear in
supporting documentation, and that the name of Digital not be
used in advertising or publicity pertaining to distribution of the
software without specific, written prior permission.
.
DIGITAL DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING
ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO EVENT SHALL
DIGITAL BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR
ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,
WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS
SOFTWARE.
Files: include/darts.h
Copyright: 2008-2013, Susumu Yata
License: BSD-3-Clause
Comment: This is darts-clone, not the original Darts library by Taku Kudo.
Files: librime-lua/*
Copyright: 2021, librime-lua Developers
License: BSD-3-Clause
Files:
librime-lua/src/lib/lauxlib-compat.c
Copyright: 2015 Kepler Project
License: Expat
Files:
librime-lua/src/lib/lutf8lib-compat.c
Copyright:
1994-2018 Lua.org, PUC-Rio.
License: Expat
Files:
librime-octagram/*
Copyright:
2014-2026 RIME Developers
2019-2021 GONG Chen <chen.sst@gmail.com>
License: BSD-3-Clause
Files:
librime-charcode/*
Copyright:
2019-2021 RIME Developers
2012-2021 GONG Chen <chen.sst@gmail.com>
2016 osfans <waxaca@163.com>
2014 Chongyu Zhu <i@lembacon.com>
License: BSD-3-Clause
Files: librime-predict/*
Copyright: 2023, RIME Developers
License: BSD-3-Clause
Files: debian/*
Copyright: 2012, Qijiang Fan <fqj1994@gmail.com>
2017, Boyuan Yang <073plan@gmail.com>
License: GPL-3.0-only
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
License: GPL-3.0-only
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License version 3 as
published by the Free Software Foundation.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
.
On Debian systems, the complete text of the GNU General
Public License version 3 can be found in "/usr/share/common-licenses/GPL-3"
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in
the documentation and/or other materials provided with the
distribution.
.
* Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Review Information
accepted — allocated to awm 19 days ago, started 19 days ago, completed 19 days ago.
Final Comment
Hi,
Thanks for the license fixes.
Looking closer I can see that librime-lua/src/script_translator.cc, table_translator.cc, translator.h, types_ext.cc — headers say Copyright (C) 2023/2022 Shewer Lu shewer@gmail.com … Distributed under terms of the MIT license.
Also librime-lua/sample/lua/{commit_history,component_test,leveldb,script_translator,table_translator,userdb}.lua — same MIT/Shewer Lu headers (2022–2024).
Additionally Files: debian/* (lines 105–108) says License: GPL-3.0-only, but debian/debian-rime-processor is explicitly CC0-1.0 (its header: SPDX-License-Identifier: CC0-1.0, lines 5–6). That file is also shipped to users via librime-bin (debian/librime-bin.install). Fix: add a stanza for debian/debian-rime-processor with License: CC0-1.0 (+ text), or a blanket CC0 policy. Minor.
Please fix these in your next upload.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 1.17.0+dfsg2-1 | c65b78c7… | 2026-10-03 05:31 | 2026-10-03 05:51 | awm | rejected | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 428 files.
NOT IN debian/copyright (1):
Shewer Lu <shewer@gmail.com>
librime-lua/sample/lua/commit_history.lua:4
librime-lua/sample/lua/component_test.lua:4
librime-lua/sample/lua/leveldb.lua:4
librime-lua/sample/lua/script_translator.lua:4
librime-lua/sample/lua/table_translator.lua:4
... and 5 more files
Result: ATTENTION REQUIRED — 1 author not in debian/copyright