Review: python-discid 1.4.2-1
Package Information
| Description | Python binding for libdiscid (Python 3) This package installs the python bindings for libdiscid to interact with it. This package installs the library for Python 3. |
|---|---|
| Maintainer | Debian Python Team <team+python@tracker.debian.org> |
| Changed By | Aryan Karamtoth <spaciouscoder78@disroot.org> |
| Sponsor | obbardc@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/python-team/packages/python-discid.git (browse) |
| Closes | #1144979 |
| Tracker | https://tracker.debian.org/pkg/python-discid |
| Uploaded | 3 days ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Fri, 21 Aug 2026 11:07:32 +0530 |
| Source | python-discid |
| Version | 1.4.2-1 |
| Changed-By | Aryan Karamtoth <spaciouscoder78@disroot.org> |
| Architecture | all source |
Changelog
python-discid (1.4.2-1) unstable; urgency=medium . * Initial release. (Closes: #1144979)
.dsc
| Section | python |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | python3-discid deb python optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/metabrainz/python-discid Upstream-Name: python-discid Upstream-Contact: Johannes Dewender <brainz@JonnyJD.net> Files: * Copyright: 2013-2026 Johannes Dewender <brainz@JonnyJD.net> 2013-2026 Philipp Wolfer <ph.wolfer@gmail.com> License: LGPL-3 Files: doc/* Copyright: 2013-2026 Johannes Dewender <brainz@JonnyJD.net> 2013-2026 Philipp Wolfer <ph.wolfer@gmail.com> License: LGPL-3 OR Expat Files: debian/* Copyright: 2026 Aryan Karamtoth <spaciouscoder78@disroot.org> License: LGPL-3 License: LGPL-3 This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. Comment: On Debian systems, the complete text of the GNU Lesser General Public License version 3 can be found in "/usr/share/common-licenses/LGPL". License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
accepted — allocated to awm 3 days ago, started 3 days ago, completed 3 days ago.
Final Comment
Hi,
Accepted, but there are still some issues which should be fixed...
debian/copyright issues
Missing copyright holder — must fix. discid/disc.py:2 and test_discid.py:3 both carry # Copyright (C) 2017 Frederik "Freso" S. Olesen, but every Files: stanza names only Johannes Dewender and Philipp Wolfer. The holder is absent from debian/copyright. Fix: add Frederik S. Olesen to the * stanza's Copyright: list (at least for discid/disc.py and test_discid.py, or as a separate stanza).
Wrong short name: LGPL-3 should be LGPL-3+. All discid/.py headers (e.g. discid/init.py:4-6) say "…Lesser General Public License … either version 3 of the License, or (at your option) any later version." DEP-5 short name LGPL-3 means version 3 only; the quoted text inside the copyright's own LGPL paragraph even reads "or (at your option) any later version" (debian/copyright:28-30). Fix: rename the short name (and the , doc/, debian/ stanzas) to LGPL-3+.
examples.py / test_discid.py are not LGPL-3+. They carry # This example/test is free. You can redistribute and/or modify it at will. (examples.py:2-3, test_discid.py:5), an informal permissive/public-domain-style grant, and no LGPL header. The * catch-all currently attributes LGPL-3 to them. Not a DFSG problem (clearly permissive), but the attribution is factually wrong; give them their own stanza or note the "at will" grant.
doc/* stanza: "LGPL-3 OR Expat" is unsupported. No file under doc/ is Expat-licensed; doc/index.rst:12-14 states the module docs are "LGNU Lesser General Public License Version 3 … or later (LGPL3+)". The "Expat" reference in debian/copyright:18 appears to be a carry-over from the relative, python-libdiscid which index.rst:36-37 mentions is Expat. Fix: doc/* should be LGPL-3+ (and the Expat paragraph then becomes unused).
Wrong common-licenses path in the Comment (debian/copyright:36-38). The comment says the LGPL v3 text lives at /usr/share/common-licenses/LGPL; on Debian that file is the LGPL-2.1 text — v3 is at /usr/share/common-licenses/LGPL-3. Fix the path (and with the short-name fix, the "version 3" wording becomes correct).
General packaging quality issues
Watch file — likely broken, verify with uscan (debian/watch:1-5). It uses Version: 5 and Version-Mangle: s/^v// (fine — upstream tags are v1.4.2), but then Template: Github + Dist: https://github.com/metabrainz/python-discid. The v5 GitHub template is parameterised with Owner:/Project:, neither of which appears; Dist: is not a field of the GitHub template (the documented field set has Source, Template, Matching-Pattern, mangle/Repack/Compression/Search-Mode/Mode/Component/Version-Constraint etc., but no Dist), and the template name Github doesn't match GitHub. As written this is unlikely to resolve the release. Recommend the canonical form:
Version: 5
Version-Mangle: s/^v//
Template: GitHub
Owner: metabrainz
Project: python-discid
Unused/odd Build-Depends (debian/control:6-15). pre-commit and ruff are upstream dev tooling (see .pre-commit-config.yaml), not used anywhere by the build (debian/rules is a bare dh $@ --buildsystem=pybuild); pre-commit in a build dependency is especially unusual. python3-sphinx, python3-sphinx-autodoc-typehints, python3-sphinx-rtd-theme are likewise never invoked — there is no doc-build override and no dh-sequence-sphinxdoc, and the binary ships no docs. libdiscid-dev is only there to pull the runtime .so for a hypothetical build-time test import (nothing is compiled; discid loads libdiscid0 via ctypes). Recommendation: drop pre-commit, ruff, and the three sphinx packages unless docs are actually built (and then add the sphinxdoc sequence/override); use libdiscid0 instead of libdiscid-dev in Build-Depends.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 1.4.2-1 | f81d2f74… | 2026-09-15 08:52 | 2026-09-15 09:11 | awm | rejected | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 28 files.
NOT IN debian/copyright (1):
Frederik “Freso” S. Olesen
discid/disc.py:2
test_discid.py:3
Result: ATTENTION REQUIRED — 1 author not in debian/copyright