Review: python-greeneye-monitor 5.0.2-1
Package Information
| Description | interface to Brultech GreenEye energy monitors This library receives binary data packets from Brultech GreenEye Monitor (GEM) devices and tracks the readings reported by multiple monitors. It exposes energy measurements for individual channels, voltage readings, pulse counts and temperature sensor values. It calculates power in watts and pulse rates from successive readings, alongside cumulative totals. An asynchronous interface provides network connections and listeners for updates to monitors and their sensor values. |
|---|---|
| Maintainer | Home Assistant Team <team+homeassistant@tracker.debian.org> |
| Changed By | Edward Betts <edward@4angle.com> |
| Sponsor | edward@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/homeassistant-team/deps/python-greeneye-monitor.git (browse) |
| Closes | #1149295 |
| Tracker | https://tracker.debian.org/pkg/python-greeneye-monitor |
| Uploaded | 23 days ago |
New Package Report
.changes
| Source | python-greeneye-monitor |
|---|---|
| Version | 5.0.2-1 |
| Changed-By | Edward Betts <edward@4angle.com> |
| Architecture | all source |
| Distribution | unstable |
| Date | Tue, 29 Sep 2026 09:06:07 +0100 |
Changelog
python-greeneye-monitor (5.0.2-1) unstable; urgency=medium . * Initial release. (Closes: #1149295)
.dsc
| Package-List | python3-greeneye-monitor deb python optional arch=all |
|---|---|
| Section | python |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: greeneye_monitor Upstream-Contact: Jonathan Keljo Source: https://github.com/jkeljo/greeneye-monitor Files: * Copyright: 2018 Jonathan Keljo License: MIT Files: debian/* Copyright: 2026 Edward Betts <edward@4angle.com> License: MIT License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to awm 22 days ago, started 22 days ago, completed 22 days ago.
Final Comment
Hi,
Licensing / DFSG issues
- Non-free vendor documentation PDFs shipped in the source, mislabeled as Expat (primary concern).
The docs/ directory contains two third-party files:
- docs/GEM-CMD_Commands_ver_10_0.pdf
- docs/GEM-PKT_Packet_Format_2_1.pdf
These are Brultech (the hardware manufacturer) device protocol/manual documents, not code authored by Jonathan Keljo. They are not covered by the MIT/Expat grant, yet debian/copyright lists them under the blanket Files: * ... License: Expat stanza, which is inaccurate for these files. Their license is undocumented/unknown, which is a genuine DFSG concern (source package contains material whose redistribution terms aren't established).
The upstream source is shipped un-repacked (5.0.2-1, not 5.0.2+dfsg-1), so these PDFs remain in the Debian source. A proper fix would be to either:
- exclude them via Files-Excluded + a +dfsg repack, or
- document their actual license in debian/copyright.
They aren't installed (only README.rst is in python3-greeneye-monitor.docs), so it's a source-only licensing gap, but still a DFSG-relevant defect.
Packaging quality issues
- debian/copyright Files: * claim is overbroad.
Covering all files (including the PDFs above) under Expat obscures the real licensing situation. At minimum, the two PDFs should have their own Files: docs/* stanza.
-
Upstream-Contact is malformed — Jonathan Keljo, has a trailing comma and no email address.
-
debian/control binary package has no Depends field.
It relies entirely on dh_python3's auto-dependency scanning to pick up the runtime deps (aiohttp, siobrultech-protocols). This generally works with pybuild-plugin-pyproject, but the runtime dependency on python3-siobrultech-protocols is declared only as a Build-Depends-Indep/test dep, and its availability in the archive is an implicit assumption that isn't visible in the binary package metadata.
Hope this is useful.
Thanks!