Review: secsipidx 2.0.0-1
Package Information
| Description | Secure SIP Identity Extensions - IETF STIR and SHAKEN Secure SIP/Telephony Identity Extensions Overview Applications and libraries implementing STIR and SHAKEN (RFC8224, RFC8588), used in SIP/VoIP services: • RFC8224 - https://tools.ietf.org/html/rfc8224 • RFC8588 - https://tools.ietf.org/html/rfc8588 This package contains CLI tool and HTTP API server for checking or Building SIP identitysecsipidx |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Victor Seva <vseva@debian.org> |
| Sponsor | vseva@debian.org |
| Distribution | experimental |
| Architecture | any |
| VCS | git: https://salsa.debian.org/go-team/packages/secsipidx.git (browse) |
| Popcon Installs | 9 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/secsipidx |
| Uploaded | 2 days ago |
New Package Report
.changes
| Distribution | experimental |
|---|---|
| Date | Thu, 05 Nov 2026 12:34:35 +0100 |
| Source | secsipidx |
| Version | 2.0.0-1 |
| Changed-By | Victor Seva <vseva@debian.org> |
| Architecture | source amd64 |
Changelog
secsipidx (2.0.0-1) experimental; urgency=medium . * New upstream version 2.0.0 * remove already applied patches upstream * golang-github-redis-go-redis-dev as Build-Depends * d/copyright: update years * bump API from 1 to 2 * remove t64 transition * d/copyright: fix BSD-3-Clause vs BSD-3-Cause-Clear * support LIBDIR config * d/control: switch to misc:Static-Built-Using field
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | libsecsipid-dev deb libdevel optional arch=any libsecsipid2 deb libs optional arch=any secsipidx deb comm optional arch=any |
| Section | libdevel |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: secsipidx
Upstream-Contact: daniel@asipto.com
Source: https://github.com/asipto/secsipidx
Files: *
Copyright: 2019-2026 asipto.com
License: BSD-3-Clause-Clear
Files: secsipid/system_cas.go
Copyright: 2009 The Go Authors. All rights reserved.
License: BSD-3-Clause
Files: secsipidx.1
Copyright: 2020-2026 Victor Seva <vseva@debian.org>
License: BSD-3-Clause-Clear
Files: debian/*
Copyright: 2020-2026 Victor Seva <vseva@debian.org>
License: BSD-3-Clause-Clear
Comment: Debian packaging is licensed under the same terms as upstream
License: BSD-3-Clause-Clear
Redistribution and use in source and binary forms, with or without
modification, are permitted (subject to the limitations in the disclaimer
below) provided that the following conditions are met:
.
* Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
* Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from this
software without specific prior written permission.
.
NO EXPRESS OR IMPLIED LICENSES TO ANY PARTY'S PATENT RIGHTS ARE GRANTED BY
THIS LICENSE. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 2 days ago.
Report
DFSG NEW review for secsipidx version 2.0.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is under the Clear BSD licence (DEP-5 short name BSD-3-Clause-Clear), which is DFSG-free, plus one file copied from the Go standard library under BSD-3-Clause. debian/copyright is in DEP-5 format with a Files: * catch-all and three narrower stanzas, names every holder found in the tree (asipto.com, The Go Authors, Victor Seva), carries the full text of both licences, and is matched correctly to the files. The only disagreements are copyright years (LICENSE says 2019-2020, README 2020-2021, the copyright file 2019-2026), which is ordinary drift.
Packaging
debhelper compat 13 with dh-golang: the Go program is built and installed by the golang buildsystem, the C shared/static library through the upstream Makefile into debian/tmp, and the three binary packages split it with dh_install patterns that use ${DEB_HOST_MULTIARCH} (supported at compat 13). The symbols file is named for the soname libsecsipid.so.2 and the package libsecsipid2, Built-Using is fed by dh_golang's ${misc:Static-Built-Using}, both patches are DEP-3-headed and forwarded, Build-Depends covers uuid, go-redis and (for the tests) expectate, Standards-Version 4.7.4 matches the reviewing system's 4.7.4.1, and the changelog's entries match what the packaging does (API 1 to 2, LIBDIR support, redis dependency, Static-Built-Using). I found nothing a sponsor would require to be changed.
Issues
None.
Verified ◂
- Read every file of
debian/in full, and every file of the tree apart from.pc/; grepped the whole tree withgitignore: falseforCopyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted,GNU General|Lesser,Apache License,Mozilla Public,public domainandAll rights reserved. Notices appear only inLICENSE,README.md,debian/copyrightandsecsipid/system_cas.go. LICENSEis the Clear BSD licence; theLicense: BSD-3-Clause-Clearparagraph indebian/copyrightreproduces it word for word, patent disclaimer included, and is given in full (there is no/usr/share/common-licensesfile for it). It is DFSG-free: attribution and name-endorsement conditions only.secsipid/system_cas.go:3saysCopied and pasted from go standard library: "crypto/x509" package!!; the matching stanza credits2009 The Go AuthorsunderBSD-3-Clause, whose full text is also present indebian/copyright. A grep forCopied|copied from|standard library|The Go Authorsfinds no other copied third-party code.secsipidx.1says in.SH AUTHORthat Victor Seva wrote it, matching the stanza that assigns it to him underBSD-3-Clause-Clear; the file is also insecsipidx_2.0.0.orig.tar.gz, so the copyright line describes an upstream file correctly.csecsipid/libsecsipid.his cgo output (Code generated by cmd/cgo; DO NOT EDIT.). Its input,csecsipid/csecsipid.go, is shipped, andcsecsipid/Makefile'sinstall-devcopies the header regenerated in_buildby thec-buildmode=c-shared/c-archivebuilds, so the installed header is not a stale committed artifact.csecsipid/secsipid.his a hand-written wrapper around it.- The files named in
secsipid/.gitignoreare not shipped and are not missing:secsipid/secsipid_test.gocreates and removesdummyCA.pem,dummyInterCA.pemanddummyCRLFile.crlitself (os.WriteFile("dummyCA.pem", certGenerator.caPEMBytes, 0777)), and thehttp_*/*.so/*.aentries cover test and build output..github/FUNDING.ymlonly names a GitHub account (github: [miconda]). - No vendored Go code:
go.mod/go.sumonly name modules that the GOPATH-mode build resolves from Debiangolang-*-devpackages;golang-github-google-uuid-devandgolang-github-redis-go-redis-devare Build-Depends, andgolang-github-gomagedon-expectate-dev <!nocheck>covers the tests. Transitive sources of go-redis (xxhash, go-rendezvous) arrive through that package's own Depends. debian/rulesbuilds through the upstream Makefile (make -C $(B) lib,install-dirs,install-lib-all) intodebian/tmp;libsecsipid-dev.installtakesusr/include/,*.a,*.soandpkgconfig/*.pc,libsecsipid2.installtakes*.so.*.${DEB_HOST_MULTIARCH}substitution in install files is available at compat 13, as the dh_install(1) example states, andDEB_HOST_MULTIARCHis exported by dpkg-buildpackage.libsecsipid2isMulti-Arch: sameand ships only files below/usr/lib/${DEB_HOST_MULTIARCH}, so the identical-files rule of Policy 5.6.34.3 holds;libsecsipid-devis deliberately not, which is right because the cgo header in/usr/includediffers between word sizes (cgo emitstypedef long long GoInt64; typedef GoInt64 GoInt;on 64-bit and 32-bitinttypes).libsecsipid2.symbolsbeginslibsecsipid.so.2 libsecsipid2 #MINVER#, matching the SONAME set incsecsipid/Makefile(-extldflags=-Wl,-soname,${SOLIBNAME},SOLIBNAME=libsecsipid.so.2) and the binary package name; the new 2.0.0 entries (SecSIPIDOptGetN,crosscall1,threadentry,x_crosscall2_ptr) carry 2.0.0, and the runtime symbols are optional/regex-matched.Built-Using: ${misc:Static-Built-Using}in all three packages is produced by dh_golang (addsubstvar($package, "misc:Static-Built-Using", $static_built_using)in/usr/bin/dh_golang), so the field is populated rather than empty; naming it explicitly is correct below compat 14.- Both patches have DEP-3 headers (
From,Date,Subject,Forwarded: https://github.com/asipto/secsipidx/pull/36) and do what the changelog says: rename the pkg-config file for the API bump and makeLIBDIR/the.pcfile configurable.debian/source/formatis3.0 (quilt). - Standards-Version 4.7.4 has the same first two components as the reviewing system's Policy 4.7.4.1, so it is current.
- The prescan's author check reported that every holder it saw is named in
debian/copyright, and it listed no individual files, so there is nothing further from the scan to account for.debian/watchwas not reviewed, per the instructions. - uscan found the packaged version as the newest upstream release (upstream
2.0.0, packaged2.0.0).
Not confirmed ◂
- No build was run, so the exact symbol set of the built
libsecsipid.so.2.0.0againstdebian/libsecsipid2.symbols, and the content of the header the build regenerates, could not be inspected; dh_makeshlibs would show them. - The Go module versions in
go.mod(notablygithub.com/redis/go-redis/v9 v9.23.0) are ignored by the GOPATH-mode build, and Debian'sgolang-github-redis-go-redis-devis 9.17.2; its sources are not installed on this system, so the go-redis API used insecsipid/cache_redis.go(Options.ContextTimeoutEnabled) could not be checked against them. A build would settle it.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 2 days ago.
Review Information
accepted — allocated to awm 2 days ago, started 2 days ago, completed 2 days ago.
Final Comment
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.0.0-1 | 1f92b77a… | 2026-11-04 11:17 | 2026-11-04 11:17 | dfsg-transition | rejected | VIEW |
| 2.0.0-1 | 6b75049b… | 2026-11-04 14:49 | 2026-11-04 14:49 | dfsg-uploader | rejected | VIEW |
| 2.0.0-1 | cb3e5494… | 2026-11-04 22:05 | 2026-11-04 22:05 | dfsg-uploader | rejected | VIEW |
| 2.0.0-1 | 9c39959b… | 2026-11-05 11:31 | 2026-11-05 11:31 | dfsg-uploader | rejected | VIEW |